JUCE icon indicating copy to clipboard operation
JUCE copied to clipboard

Un-constify getProgramName return value

Open danra opened this issue 5 years ago • 0 comments

getProgramName unconventionally returns const String rather than just String, and so triggers various warnings. Besides having no advantage AFAICS*, clang-tidy triggers the readability-const-return-type warning on this.

This is a breaking change for existing overriders, though (*which is a valid reason to keep as-is, though not a great one), so if the pull request is accepted it should also be listed under the breaking changes.

danra avatar Dec 29 '19 14:12 danra