fake-s3 icon indicating copy to clipboard operation
fake-s3 copied to clipboard

[Bug] Access-Control-Allow-Origin:* not present in 404 response headers

Open samuel-belcastro opened this issue 7 years ago • 3 comments

To reproduce:

  1. Send a HEAD request to a fake-s3 bucket file that does exist from a different origin than the bucket. Check the response headers and verify Access-Control-Allow-Origin:* is present.
  2. Send a HEAD request to a fake-s3 bucket file that does not exist from a different origin than the bucket. Access-Control-Allow-Origin:* is not present in the response headers.

samuel-belcastro avatar Aug 01 '17 15:08 samuel-belcastro

@jubos I have a fix for GET and HEAD requests. If you see this as an important issue, let me know and I'll create a pull request and do the testing. Otherwise you can close this, and I will use my fork.

samuel-belcastro avatar Aug 02 '17 16:08 samuel-belcastro

Seems like a worthwhile fix, let me know when you have your diff ready.

jubos avatar Aug 05 '17 16:08 jubos

Diff is ready: https://github.com/jubos/fake-s3/pull/217

Please let me know when you are able to get this merged in.

samuel-belcastro avatar Sep 20 '17 15:09 samuel-belcastro