awesome-os icon indicating copy to clipboard operation
awesome-os copied to clipboard

Add thor-os

Open opensourcecollaborationnow opened this issue 2 years ago • 5 comments

Hi jubalh :)

So, I would like to release this operating system: thor-os

Note: I updated README.md with thor-os, thor-os is simple operating system in C++, written from scratch. reference: https://github.com/wichtounet/thor-os

As promised, one more operating system on the list :D

thank you for accepting my pull request, this is really cool :)

A few things:

  • Make your commit subjects look like: Add thor-os instead of updated readme with... Since this project only contains a readme this makes more sense.
  • Let's omit filling worlds like 'simple', 'small' etc since probably too many projects would claim this.
  • Don't repeat the name of the os after you listed it.

So in this case I would just write * [thor-os](https://github.com/wichtounet/thor-os) - Written in C++ from scratch.

jubalh avatar Sep 27 '21 08:09 jubalh

And if you want to add multiple OSes you can create multiple commits but one pull request containing those commits is enough.

jubalh avatar Sep 27 '21 08:09 jubalh

Thanks for the feedback. If possible, could you check the change I made?

I await your reply.

ghost avatar Sep 28 '21 01:09 ghost

Yes, but now you made two commits. Please squash them together next time. git rebase -i head~2 and then git push -f.

jubalh avatar Sep 28 '21 08:09 jubalh

ping

jubalh avatar Apr 26 '22 13:04 jubalh