diart icon indicating copy to clipboard operation
diart copied to clipboard

Tuning parameters are initialized wrong.

Open nikifori opened this issue 9 months ago • 1 comments

Based on this code here: https://github.com/juanmc2005/diart/blob/392d53a1b0cd67701ecc20b683bb10614df2f7fc/src/diart/blocks/diarization.py#L50

it seems that attributes like duration and etc. are initialized with an "_" before their name.

This raised an issue here: https://github.com/juanmc2005/diart/blob/392d53a1b0cd67701ecc20b683bb10614df2f7fc/src/diart/optim.py#L111

SpeakerDiarizationConfig class does not contain any _latency or _duration argument in its __init__ method. Thus, always the default values of all the arguments with "_" before their name is going to be used in the tuning phase, even if we pass --duration 10 and etc.

nikifori avatar Feb 18 '25 15:02 nikifori

@nikifori thank you for reporting this!

juanmc2005 avatar Feb 25 '25 09:02 juanmc2005