diart icon indicating copy to clipboard operation
diart copied to clipboard

Published 20 hours ago • verified publisher icon juanmc2005

Support multiple client connections over Websocket

Open janaab11 opened this issue 1 year ago • 3 comments

Looked at the WebSocketAudioSource class to realise that the server will only support one client at a time. Also leads to this weird (but expected, i guess) behaviour - when two clients connect sequentially, the later one has response offsets that carry over from the first one.

I can see a way to add multi-client support - happy to make a PR - but wondering if this choice is intentional? And if i am missing something?

New here, and really appreciate the detail and thought that has gone into this work already!

janaab11 avatar Nov 17 '24 18:11 janaab11

Hi @janaab11, thank you for opening this PR! Indeed the single-client is a limitation and would be glad to make it multi-client. I'll review your PR.

juanmc2005 avatar Dec 13 '24 09:12 juanmc2005

Could you please open the PR against the develop branch of diart instead of your fork? Then I'll be able to review it. Thanks!

juanmc2005 avatar Dec 13 '24 09:12 juanmc2005

Hi @juanmc2005, i have opened the PR. Sorry for the delay, look forward to working on this!

janaab11 avatar Dec 22 '24 18:12 janaab11