headscale icon indicating copy to clipboard operation
headscale copied to clipboard

Replace magic-nix-cache-action

Open Hasnep opened this issue 6 months ago • 1 comments

Headscale is open to code contributions for bug fixes without discussion.

Hopefully this counts as a bug fix 😅 If not, I'm happy to close the PR and discuss the change :)

The DeterminateSystems/magic-nix-cache-action action has been deprecated and no longer works. This PR replaces it with the nix-community/cache-nix-action action, which is actively maintained. It also replaces the DeterminateSystems/nix-installer-action action with the nixbuild/nix-quick-install-action action, which is required for the cache action to work. The cache has been configured to restore based on the runner's OS and architecture, so it should work on any runner.

  • [x] have read the CONTRIBUTING.md file
  • [ ] raised a GitHub issue or discussed it on the projects chat beforehand
  • [ ] added unit tests
  • [ ] added integration tests
  • [ ] updated documentation if needed
  • [ ] updated CHANGELOG.md

Hasnep avatar May 09 '25 03:05 Hasnep

Pull Request Revisions

RevisionDescription
r1
GitHub Actions Nix Actions UpdatedReplaced DeterminateSystems Nix actions with alternative nixbuild and nix-community actions, added caching configuration with primary key and restore prefix.

✅ AI review completed for r1
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at [email protected].

ghost avatar May 09 '25 03:05 ghost

I think you missed the update nix workflow, can you have a look at that?

kradalby avatar May 14 '25 14:05 kradalby

I think you missed the update nix workflow, can you have a look at that?

We should do a follow up here. Merged because jobs broke on my drafts prs.

kradalby avatar May 26 '25 21:05 kradalby