headscale icon indicating copy to clipboard operation
headscale copied to clipboard

Make more granular SSH tests for both Policies

Open kradalby opened this issue 7 months ago • 1 comments

kradalby avatar May 02 '25 13:05 kradalby

Pull Request Revisions

RevisionDescription
r8
Removed duplicate import in test fileEliminated a redundant import of the matcher package in the policy_test.go file
r7
SSH policy reworked with new validationComprehensive refactoring of SSH policy validation with stricter rules, improved autogroup handling, and enhanced error checking across policy sources, destinations, and users.
r6
Updated Nixpkgs flake lockUpgraded Nixpkgs dependency to a newer commit with updated hash and modified lastModified timestamp
r5
Modified autogroup validation logicUpdated autogroup validation to check against a new unsupported autogroups slice instead of previous containment checks
r4
Removed autogroup:nonroot from SSH policyUpdated SSH policy test case by removing autogroup:nonroot from users and test case configurations
r3
SSH policy reworked for consistencyUpdated SSH policy to align with Tailscale upstream, modifying test cases to use specific user destinations instead of groups
r2
Skipped SSH policy test casesAdded skipV1: true to multiple SSH policy test cases due to broken group implementation in v1
r1
Added comprehensive SSH policy testsExpanded SSH policy testing in policy_test.go with multiple scenarios for SSH rule matching, validation, and policy generation across different user and tag configurations

✅ AI review completed for r8
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at [email protected].

ghost avatar May 02 '25 13:05 ghost