headscale icon indicating copy to clipboard operation
headscale copied to clipboard
verified publisher icon juanfont

feat: Add autogroup ACLs

Open gabe565 opened this issue 1 year ago • 7 comments

I have taken @vinhjaxt's autogroup implementation from https://github.com/juanfont/headscale/issues/657#issuecomment-2336625885, added some code improvements, fixed lint, and added tests. This is still a WIP, but so far it's working as intended.

  • [x] have read the CONTRIBUTING.md file
  • [x] raised a GitHub issue or discussed it on the projects chat beforehand
  • [x] added unit tests
  • [x] added integration tests
  • [ ] updated documentation if needed
  • [x] updated CHANGELOG.md

Fixes #657

gabe565 avatar Nov 08 '24 18:11 gabe565

Im on holiday so wont have time to take a look for a few weeks but wanted to just jump in and say that I have started work to redo the policy code, there is a draft pr, but its very draft pending many changes.

I don't imagine I would add anything new to the policy as is, so this should be added on top of the new work. That said it might not be in the final state and it might be hard to do so yet.

I do appreciate you picking this up, and would love to see it in when we get there.

kradalby avatar Nov 08 '24 19:11 kradalby

Really waiting for this feature!

AdamsGH avatar Dec 30 '24 23:12 AdamsGH

Hey, any update here. Really looking forward to this function and kind of blocked without it (without changing from using main image)

danscarfe avatar Jan 17 '25 22:01 danscarfe

I have reimplemented this in policy v2 and will test it more in my home lab environment to see if it's working as expected. It's pretty much the same logic as the code here, but it is done in the way policy v2 is written.

vdovhanych avatar Apr 03 '25 12:04 vdovhanych

Sounds sensible, main criteria is tests, happy also to help with it as we want to get there eventually, but might say thst we want to wait one release with this one

kradalby avatar Apr 03 '25 17:04 kradalby

Sounds sensible, main criteria is tests, happy also to help with it as we want to get there eventually, but might say thst we want to wait one release with this one

Please please please can we have it. We're waiting on it for a super cool project at https://xrai.glass. Happy to tell you more.

danscarfe avatar Apr 03 '25 21:04 danscarfe

https://github.com/juanfont/headscale/releases/tag/v0.26.0-beta.1, new beta is out, I think it should be fairly safe to rebase this onto that branch and if we get it proper tested it should be something we can get into 0.27.

Targeting 0.27, no v1 code needs to be considered.

kradalby avatar May 04 '25 22:05 kradalby

I'm going to close this in favour of @vdovhanych's PR, and some collaborations on getting this in as this PR is out of date.

kradalby avatar May 14 '25 14:05 kradalby