juancarloscp52
Improve So Sweet! event
The original implementation had an issue where the checkerboard would be alternating between different y levels, resulting in it not properly continuing when the bushes were placed across varying-height terrain:
This PR fixes this by only using x/z to get the checkerboard pattern, and then looping through the the Y column from 4 blocks below to 4 blocks above the player to check for placeable positions.
An additional small improvement has been made, moving the creation of the bush block state to a non-static field. This way it is not unnecessarily recreated multiple times (once per iteration) when the event is run.
Originally this effect was "Place Sweet Berry Bush". Effect used to place 1 berry bush like Place Lava or Place Cobweb effect. After watching some people play with chaos mod I notice that effect did almost nothing, therefore i decided to make field of bushes instead. Main goal was to still place bushes around the player ever if player is not near the grass/dirt blocks, like being underground or in the nether. Because next to the player there may not be blocks that bushes can be placed, and if you place 2 bushes next to each other they will update each other and destroy themselves, chess pattern was chosen.
So, I agree with moving block state into static field. I neutral toward the chess pattern for varying-height terrain because initial goal was not to make chess pattern but prevent bushes destroy themselves. I disagree with moving bushes to world's MOTION_BLOCKING heightmap because it means that effect will no longer affect players underground and in the nether.
Thanks for the explanation, I agree with your concerns. The main motivation for this PR was indeed the correction to the checkboard pattern, which the heightmap change was an easy solution to. In hindsight however, I should have thought more about this change, and that would have led to the same conclusion you had. I'll revisit the checkerboard pattern correction without using the heightmap.