qutebrowser-profile icon indicating copy to clipboard operation
qutebrowser-profile copied to clipboard

Avoid file/dir name collisions by putting profiles in an isolated location

Open jvinet opened this issue 5 years ago • 4 comments

Moved profile root to $XDG_DATA_HOME/qutebrowser/profiles so profile names cannot collide with Qutebrowser data files (eg: webengine)

jvinet avatar Apr 19 '21 15:04 jvinet

Thanks for the PR! Good thinking, this is sensible. I've left one comment on it - once that's resolved we can merge.

On versioning, at the moment this just has a straight master branch, but I can see it would benefit folks to have versioning around this as it appears to get some usage, so I'll put up a separate issue for that.

jtyers avatar Apr 26 '21 10:04 jtyers

No problemo. Updated!

jvinet avatar Apr 26 '21 16:04 jvinet

This looks good to me, but is a breaking change. A release note should be added to note that manual migration is required for the upgrade by creating the directly and copying the folders into it.

markstos avatar Jun 21 '21 15:06 markstos

Thanks for your work on this folks. I've re-implemented qutebrowser-profile in Python which solves a few headaches with its implementation. Would it be possible to re-work this PR in Python?

I agree with @markstos that, as a breaking change, we need to add it to release notes. We may also be able to automate migration in most cases so perhaps should consider that (though I'm not sure how wide our userbase is!)

jtyers avatar Nov 29 '23 20:11 jtyers