ambit icon indicating copy to clipboard operation
ambit copied to clipboard

Code Improvements

Open jturney opened this issue 8 years ago • 4 comments

Improvements

The following are improvements to Ambit that were brought up during the Tensor discussion at Emory with Psi4 developers:

  • [ ] Batching blocks/slices to/from disk
  • [ ] Memory manager
  • [ ] Improved algorithm for contraction chain
  • [ ] Permutational symmetry
  • [ ] Point group symmetry
  • [ ] Finish DiskTensor and ensure compatibility with CoreTensor.

Tests to conduct

  • [ ] With current distributed infrastructure, how does CTF perform. We fully acknowledge that we do not utilize CTF fully.
  • [ ] I have a GlobalArrays backend for Ambit that needs to be tested and benchmarked.

jturney avatar Jun 07 '16 21:06 jturney

As a note id really like to separate symmetry and contraction chains from the underlying tensor class. Derived classes can be as complicated as needed, but there should be a base class that is as bare bones as possible.

dgasmith avatar Jun 07 '16 21:06 dgasmith

That is already the design of the base class. Rob and I wanted the base class to be as minimal as possible. The contraction chains are handled by expression templates. Symmetry will likely follow the BlockedTensor class style.

jturney avatar Jun 07 '16 21:06 jturney

Hey @jturney, I am working at PNNL for the next few months. I will be planning on implementing DSRG with global arrays. I would be more than willing to test GlobalArrays for Ambit. Can you push those changes to Ambit? Or send me the code?

kannon92 avatar Jun 08 '16 17:06 kannon92

@kannon92 Sure thing! I'll locate it and send it your way.

jturney avatar Jun 08 '16 19:06 jturney