Wave icon indicating copy to clipboard operation
Wave copied to clipboard

macOS version

Open erikng opened this issue 2 years ago • 4 comments

I don't know how feasible this would be as you use a lot of UIKit, but what about some level of AppKit support? I don't mean Catalyst support as I imagine that may work out of the box.

Maybe next week Apple will announce something to better bridge the gap.

If this is something you don't ever want to support, feel free to close this. Awesome work!

erikng avatar Jun 01 '22 12:06 erikng

I managed to fully port Wave to MacOS & NSView. It works great. :) When I find time I will clean up my code and will upload it.

flocked avatar Jun 03 '22 11:06 flocked

Nice!

erikng avatar Jun 03 '22 11:06 erikng

Here it is. It just misses a sample project https://github.com/flocked/Wave/tree/main

It's my first time ever trying to combine iOS/macOS into one shared code. So there might be better code. It surprisingly didn't require a ton of changes.

flocked avatar Jun 03 '22 17:06 flocked

Hi @flocked, thank you for exploring this!

I’m still figuring out Wave’s contribution guidelines, but I think for issues that affect architecture/introduce features, I probably will provide a patch myself.

But more broadly, yes, I would love Wave to support macOS.

jtrivedi avatar Jun 03 '22 18:06 jtrivedi

Hey @erikng and @flocked, I'll be landing macOS/AppKit support in Wave soon with this PR.

Feel free to reach out with any questions or issues!

https://github.com/jtrivedi/Wave/pull/25

jtrivedi avatar Nov 14 '22 01:11 jtrivedi

Resolved with #25

jtrivedi avatar Nov 14 '22 17:11 jtrivedi