StarCluster icon indicating copy to clipboard operation
StarCluster copied to clipboard

Published 20 hours ago • verified publisher icon jtriley

Static security groups

Open dmachi opened this issue 13 years ago • 9 comments

This small set of patches allows one to define static_security_groups as part of a clusters config. Doing so adds the cluster nodes to the named security groups in addition to the sc defined security group.

dmachi avatar Feb 05 '12 22:02 dmachi

Sorry, I branched from the sge-plugin branch, and so this pull request is asking for more than I am really asking for. Only 3ff18d0 is the commit I am placing here.

dmachi avatar Feb 05 '12 22:02 dmachi

@dmachi This pull request looks good, the only thing I'd add is some validation to make sure the specified security groups actually exist before trying to launch the cluster. If we could add a Cluster._validate_static_groups method and then call this method from Cluster._validate that would be awesome...

jtriley avatar Feb 24 '12 14:02 jtriley

@dmachi also it'd be nice to update the docs for this new feature

jtriley avatar Feb 29 '12 18:02 jtriley

sounds good, i'll add these changes in.

dmachi avatar Mar 05 '12 23:03 dmachi

Since this thread has been inactive for a few months, I went ahead and:

  1. Forked jtriley/StarCluster.
  2. Merged dmachi@3ff18d0edcb6a5a1b53fc7f504a129af2610ba31.
  3. Added the requested validation and documentation.

@dmachi, feel free to merge my changes so that this pull request can be merged.

If nothing happens with this, I will eventually add make my own pull request.

mikepfirrmann avatar Aug 10 '12 17:08 mikepfirrmann

@mikepfirrmann Awesome, thanks for adding validation and docs. I can merge your changes with this PR manually when I get to this pull request in case @dmachi hasn't added them by then. Sorry for the delay @dmachi...lots of tasks to catch up on.

jtriley avatar Aug 10 '12 17:08 jtriley

Thanks@mikepfirrmann, I got behind on those additions @jtriley requested.

dmachi avatar Jan 03 '13 17:01 dmachi

Hey guys, I've been trying to use StarCluster with my company's custom security group and would greatly appreciate seeing this feature added to StarCluster. I have some unique constraints though:

  • I need to use a security group tied to my IAM
  • My IAM is not allowed to create additional security groups, so I must use only a static security group (and not the group that StarCluster creates by default).

I've tried using the implementation of this feature in mikepfirrmann's fork ( as of mikepfirrmann@ddb69ccdcdb52bd00081383517bcdace614c165d ) and I had to fix a couple tiny bugs to get the feature running. The feature appears to find and use my company's custom security group, but StarCluster still tries to create an additional group and thus crashes (because my IAM doesn't have permissions to do this).

I have a couple of questions:

  • Since I have a pressing need for this feature, would it help at all for me to fork & fix mikepfirrmann's patch and submit a new pull request?
  • Is there any way to make StarCluster use exactly one security group (i.e. a static one) for a cluster and skip creating a new security group for the cluster?

And thanks to everybody who has contributed to this fantastic project!

ypwais avatar Feb 06 '13 09:02 ypwais

Does anyone have a solution to ypwais's problem. I am in a similar situation that I don't have permission to create my own security group, and need a static security group to run StarCluster? this is very critical for me

howardlinus avatar May 20 '15 14:05 howardlinus