StarCluster icon indicating copy to clipboard operation
StarCluster copied to clipboard

Python 3 Support

Open jseabold opened this issue 9 years ago • 14 comments

Would be great if starcluster were installable on Python 3.

jseabold avatar Mar 21 '15 00:03 jseabold

Dropping in here to echo the same sentiment.

mbaltrusitis avatar Mar 26 '15 00:03 mbaltrusitis

+1

lmarti avatar Mar 30 '15 05:03 lmarti

Desperately

rhara avatar Apr 03 '15 05:04 rhara

+1

Update:

I've started work on this here:

  • https://github.com/oubiwann/StarCluster

Just got a successful build in Python 3.4.2, but haven't tried using it yet ...

Note: that is a fork of @golharam's fork here:

  • https://github.com/golharam/StarCluster

oubiwann avatar Apr 10 '15 14:04 oubiwann

@oubiwann any chance on making a PR, so it can be reviewed?

jseabold avatar Jul 15 '15 18:07 jseabold

+1

jakepopham avatar Jul 16 '15 02:07 jakepopham

+1

sebastien-bratieres avatar Jul 16 '15 12:07 sebastien-bratieres

A couple of comments on the fork:

  • I needed a bunch of stuff that @golharam's fork had, so it's based off of that -- as such, a PR back to @jtriley's repo wouldn't be a good idea (unless golharam's has been merged)
  • I only needed some of StarCluster's functionality (deadline situation); not everything has been tested for Python 3 support.
  • I haven't tested any of the changes in Python 2.x :-/ I used six, so most things should be okay. But we all know how that sort of thing often goes ...
  • All the efforts were focused on client-side usage (StarCluster command line tool); no changes have been made with the intent of ensuring that Python 3 runs on EC2 instances.

All this being said, I think the work done accounts for anywhere from 70-90% of what's needed to have Python 3 supported client-side. I don't currently have the time to push this forward, but I could help coordinate, if folks wanted to submit PRs to the https://github.com/oubiwann/StarCluster repo. At the very least, we could iron out all the issues and submit the work for inclusion in @golharam's fork.

Any explicit work needed to support Python 3 on EC2 should probably go in another branch.

Thoughts?

oubiwann avatar Jul 16 '15 23:07 oubiwann

Let me know how I can help. I thought my changes were minimal. I'll do what I can.

Ryan (golharam)

Sent from my iPhone

On Jul 16, 2015, at 7:59 PM, Duncan McGreggor [email protected] wrote:

A couple of comments on the fork:

I needed a bunch of stuff that @golharam's fork had, so it's based off of that -- as such, a PR back to @jtriley's repo wouldn't be a good idea (unless golharam's has been merged) I only needed some of StarCluster's functionality (deadline situation); not everything has been tested for Python 3 support. I haven't tested any of the changes in Python 2.x :-/ I used six, so most things should be okay. But we all know how that sort of thing often goes ... All the efforts were focused on client-side usage (StarCluster command line tool); no changes have been made with the intent of ensuring that Python 3 runs on EC2 instances. All this being said, I think the work done accounts for anywhere from 70-90% of what's needed to have Python 3 supported client-side. I don't currently have the time to push this forward, but I could help coordinate, if folks wanted to submit PRs to the https://github.com/oubiwann/StarCluster repo. At the very least, we could iron out all the issues and submit the work for inclusion in @golharam's fork.

Any explicit work needed to support Python 3 on EC2 should probably go in another branch.

Thoughts?

— Reply to this email directly or view it on GitHub.

golharam avatar Jul 17 '15 03:07 golharam

@golharam If you could make a PR against this repo to explain and get your changes in, I think that'd be a great start. I think the community would benefit from keeping things centralized.

jseabold avatar Jul 23 '15 14:07 jseabold

@oubiwann Actually it doesn't really matter where the fork was made from, if you want to submit a PR with both sets of changes to this repo you can. The change sets should probably be separated, but I'm just thinking about the path of least resistance. If you feel like it, you could even make a branch with just @golharam's changes and then one with yours.

@jtriley Can you comment on what the maintenance status of starcluster is, before people go to great lengths trying to get things in shape to merge? Interested in any help on reviewing and merging some of the outstanding PRs? Should we start working on one of the other forks?

jseabold avatar Jul 27 '15 15:07 jseabold

Python 3(.5) support would be great +1!

wbinventor avatar May 23 '16 16:05 wbinventor

Is it okay to use 2to3.py to make Starcluster work under python3 framework? @oubiwann @jtriley @golharam

hitblz avatar Feb 11 '17 01:02 hitblz

Any idea as to the status of this?

I can't even install pip3 on the clusters.

ryanpeach avatar Oct 13 '17 15:10 ryanpeach