Joe Topjian

Results 140 comments of Joe Topjian

Thank you for researching this - it's good checklist to have. I think we can either disregard the following or make them a very low priority because they're either deprecated...

@pierreprinetti This issue is more like a meta issue for small and other random PRs that are only touching acceptance tests. This issue can totally be closed if you'd like.

> @jtopjian do you have thoughts on this one? There are some discussions in older, closed issues where I am firmly against this - specifically the removal of blockstorage v1....

@mia-huang-cmu Thank you for reporting this issue. > This can be fixed simply by make a deep copy of options.RawBody. Wouldn't this cause the contents of `RawBody` to be stored...

Ditto - I am in favour of removing this.

Yeah, the `stacks` package was designed a little differently than other packages in Gophercloud. It has a lot of tests written for internal methods (all the ones listed as unexported)...

Thanks for reaching out! This is an interesting proposal and I like the idea of it. Before jumping right in, I have a few questions: 1. We can think of...

1, 2, and 3 all sound good. I haven't had time to look at the code you linked, but from your description of: > We do not leverage any of...

This all sounds good to me. I think we can proceed with giving this a shot. I did a cursory review of the zip attachment. I think the "patch" stuff...

> I think this is my preferred approach This is mine as well - it's the better long-term approach. > By "Create a PR for each of the different services"...