Jared Tobin
Jared Tobin
Note that these error codes are described briefly in [bLIP29](https://github.com/Roasbeef/blips/blob/tap-blip/blip-tap.md#last-mile-routing), so any practical change here may need a corresponding update there, or *vice versa*.
You're right -- there's nothing stopping tapd from receiving an error code of 0, but relaying a custom message. I'll reopen that one and we can pick it up there.
I'm actually going to close this because I now (only a few hours later) think it to be misguided. Absent any pressing need, we probably shouldn't mess with error codes...
I'm reopening this, because I again think it to be.. uh, appropriately guided. The crux is that a useful distinction can be made between the codes for *RFQ rejection errors*,...
The idea here seems to me to be that Alice should first consult her oracle before engaging in an RFQ with Bob, so that if there's any preliminary problem (like...
(I reworded the title and adjusted the labels to try and better-capture the issue as it appears to me after review.)
(Adjusted the title and labels after review.)
We can probably remove the v0.7 milestone from this one, given #1836 has been merged.
I think the raw-byte script_key fields must be legacy definitions using the compressed encoding (if there's *one* byte prepended).
Closing this one in favour of #1749, which subsumes it.