James Thomas Moon

Results 69 comments of James Thomas Moon

Latest PR push also includes a few extra tests in `test_rfc3339` that were folded into a prior commit. Hence the force push https://github.com/chronotope/chrono/pull/807/files#diff-abd7a03adfeaa1c9ca4623371f789cf48c5d794d82457a4068ad5be00fe7c784R1458-R1492

FYI the last PR update was a rebase to `main`. Unfortunately, command `cargo test` now prints several warnings regarding deprecated functions, e.g. ```text warning: use of deprecated associated function `offset::TimeZone::ymd_opt`:...

@esheppa don't mean to pester, just wondering if you saw this updated PR? I know you both maintain this project on your own time, so whenever.

I think this is ready to merge. I'm a little concerned about my decision to allow some flexibility in the timezone offset matching, e.g. patterns `00:00`, `00 :00`, `00: 00`,...

On a different topic, would you like help reviewing Issues and PRs for this project? It's an important project and it seems like some assistance would help. Since I have...

> Would it be feasible to squash the current commit history down Squashed. > Your help with maintaining this project would be much appreciated! I'll subscribe to the github alerts....

I came across this issue because while adding a line to a `Dockerfile`, I naturally wrote ENV DOCKERBUILDHOST $(hostname) which made sense to me. But this merely added environment variable...

@thaJeztah The `--build-arg ...`→`ARG ...`→`ENV ...` suggestion also works and it's less ugly than other workarounds. If I may gripe a wee bit... the need to run some command on...

> The issue there, is that those commands should _not_ run on the _host_ but inside the container @thaJeztah pardon to belabor this thread, I'm curious about the reasoning behind...

> those are the files that are sent to the daemon where the build is executed, using the context (files/folders) that it was given access to. > ... > Instructions...