VAD icon indicating copy to clipboard operation
VAD copied to clipboard

Can Octave be used?

Open vladfulgeanu opened this issue 7 years ago • 10 comments

Is there a way in which Octave can be used instead of Matlab for running the main.m file? When I try to run it using Octave I get:

warning: called from
    main at line 5 column 1
warning: function ./lib/matlab/stft/example.m shadows a core library function
warning: called from
    main at line 5 column 1
MRCG extraction ...
ans = 1
ans = 1
warning: load: '/home/vlad/Downloads/VAD/lib/matlab/MRCG_features/f_af_bf_cf.mat' found by searching load path
warning: called from
    loudness at line 12 column 1
    gammatone at line 35 column 10
    MRCG_features at line 7 column 3
    mrcg_extract at line 26 column 14
    vad_func at line 7 column 30
    main at line 21 column 12
.........................
error: fftfilt: B must be a vector
error: execution exception in main.m

vladfulgeanu avatar Feb 14 '18 12:02 vladfulgeanu

I made a fork where I think I've fixed that by unrolling the loop which can be found here https://github.com/TheCacophonyProject/VAD I also made some small other changes to get it working on windows, and with stereo audio files.

maitchison avatar Feb 24 '18 01:02 maitchison

Rather than Octave, we have a plan to write our code only using the python. please wait for it thank you!

jtkim-kaist avatar Feb 25 '18 09:02 jtkim-kaist

A full Python implementation would be awesome!

charlescc9 avatar Mar 01 '18 22:03 charlescc9

Python would be great! For the moment I submitted a PR with just the Octave change. It does slow things down a bit though, so I only run the Octave version if we are actually on Octave.

This is a great library by the way, really appreciate the work!

maitchison avatar Mar 06 '18 04:03 maitchison

Good news! a full python implementation is upcoming (to be updated until 2018/03/17)

jtkim-kaist avatar Mar 09 '18 12:03 jtkim-kaist

When can we expect the python implementation?

shezanmirzan avatar Apr 02 '18 06:04 shezanmirzan

Sorry for the late update, we already have a fully python written test script however, the train script has been delayed. We will firstly update test script in this week sorry.

jtkim-kaist avatar Apr 04 '18 15:04 jtkim-kaist

  • NOTE, we uploaded the test script fully written by python in py branch.

jtkim-kaist avatar Apr 08 '18 18:04 jtkim-kaist

Thanks for the test script. Could you also upload the train script soon?

wishvivek avatar Sep 12 '19 17:09 wishvivek

Yeah, a train script not depending on matlab would be great.

sh: 1: matlab: not found

Linus789 avatar Apr 17 '20 04:04 Linus789