cljs-workers
cljs-workers copied to clipboard
A library mod
Hello. Thanks for the great library! I'm using a heavily modified version of it in my own lib https://github.com/cljs-audio/cljs-audio/tree/master/src/main/cljs_audio/workers. I've changed the code to use transit for data serialization/deserialization. I'd be glad (and I'm obliged) to credit you, but not sure how. I can also extract the code and create a PR if this is something you'd like.
Hi @Nek, thank you for you support.
Thanks for the great library! I'm using a heavily modified version of it in my own lib https://github.com/cljs-audio/cljs-audio/tree/master/src/main/cljs_audio/workers.
Cool 👍
I'd be glad (and I'm obliged) to credit you, but not sure how.
These days there is no way to credit me, but that triggered me to look into a support option.
I've changed the code to use transit for data serialization/deserialization. ... I can also extract the code and create a PR if this is something you'd like.
PRs are always welcomed. I took a look into your changes. What was your reason to use a string based format (transit) for data transfer? I see problems at least for "transfered" data switching the monitoring thread. I would guess it cant work this way with transit, do you tested it?
Best regards Julian
Hey @jtkDvlp , I have to say my reason was pretty simple, it fixed the problems with deeply nested data structures, and it worked. I didn't think thoroughly about the benefits and drawbacks of my specific solution. So, no, haven't tried any other way, but yes, you are right about the thread switching.