Results 37 comments of Julie Tibshirani

Thanks @michaellzc for chiming in. To clarify what I'm looking for: I'm trying to repro locally, say on the sg/sg repo, so I can step through and understand why these...

We merged two quick fixes to prevent panics + crashes: * https://github.com/sourcegraph/sourcegraph/pull/60844 * https://github.com/sourcegraph/sourcegraph/pull/60878 What's left before we close this issue is following up with more robust fix.

As a tactical fix, I wonder if we should remove the modeline detection in our `go-enry` wrapper? I'd be really curious to understand how much it helps in practice.

Potentially related: https://github.com/sourcegraph/sourcegraph/issues/45734

Sorry for my own drive-by comment, I found the logic in the last PR (#85185) a lot more focused and easy to understand. Would it make sense to start with...

@shubham149 I'm sorry for the very slow response here! Confirming I understand: when you say "crash consistent", you mean snapshot consistency. For example, if Zoekt was indexing a new commit,...

CC @novoselrok since I heard you worked on something similar -- please ignore if this isn't right!