Broken with Mediawiki 1.37.1 [solved]

[fw25]

Setup

• Browsers and versions: Firefox 78, Brave 1.36.111 and Chrome 99.0.4844.51
• MediaWiki version: 1.37.1
• Database version: 5.5.68-MariaDB
• PHP version: 7.4.28 (cgi-fcgi)
• Foreground version: 2.4.1
• Extension version (if connected to the issue):

Issue

Detailed description of the issue goes here. There is an jquery error in a javascript file it is about url.indexOf. It cripples the internal links.

[fw25]

There is a simple workaround. Replace load with on(“load”

assets/scripts/foundation/foundation.topbar.js replace in line 248 }, 50)).trigger('resize.fndtn.topbar').load(function () { with }, 50)).trigger('resize.fndtn.topbar’).on(“load”,function () {

assets/scripts/foundation/foundation.js replace line 345 S(window).load(function () { with S(window).on("load",function () {

[racribeiro]

Yes, this works.

Please consider pushing this change to the repository.

[Hutchy68]

If someone opens a pr against develop branch I’ll merge.

[rebastion]

@fw25 it does give a "Uncaught SyntaxError: '' string literal contains an unescaped line break" error in the debugger though, did I copy paste something wrong?

[rebastion]

Works if done like this https://github.com/jthingelstad/foreground/commit/82bbd1539eb628882eeaff8b8f16bcc2e50d098f