James Hegedus
James Hegedus
Sweet, I am glad it works! Checkout the rest of the readme, especially the `future` section for my recommendations going forward for React & Firebase etc
I have not had any issues with hot-reloading with `next dev`. The `server.js` is intended to be the small glue between Next.js and Cloud Functions. I haven't tested any hot-reloading...
@joshleong Hey mate, I found a bug in the `scripts/export.js` script, so you might want to resync that file with what's in `master` now. Also, have you tried the `firebase...
Yeah, I could never get preview mode to work when I wrote that example. I haven't delved into why that is the case. When you say you can get it...
Yeah definitely, I was going to look into the details eventually 😅 Added to caveats in https://github.com/jthegedus/firebase-gcp-examples/commit/061668b69a0b1bc4e699a7d5fe7d705ee91db4d4 If you continue to investigate and get this working, please share here!
I think the test cases would have to be all on Firebase. It does not surprise me it works on Vercel without any special config as their platform knows how...
Oh, so you found an issue with preview mode when deployed to Vercel with a custom `distDir`?
I personally think providing the error as an Action Step Output is different to enabling the Action to comment the issue and a suggestion on the PR itself. I would...
As I state above, I think commenting on PRs and Action outputs are different. Can we reopen this or should I create another Issue to specifically track comments on PR...
>Having a comment repeat what a check already provides doesn't seem useful to me. I disagree. Seeing that the check failed does not tell you **why** it failed. You have...