print config v2 Issue #191
@jtesta @daniejstriata
- printconfig script
- test_printconfig for tox testing
- update globals for GUIDES_UPDATED date value
- update ssh_audit for print_config argument and checks
Quotes should no longer be needed. usage : ssh-audit.py --print-config Ubuntu 2204 Server
Hi Joe,
As always, thanks for the review and feedback. I'll look into the changes and get back to you.
Again I will try and update and attempt to squash everything, and again if it turns into a mess - I'll close this one of and create a clean PR when the code is a bit closer to a second review.
Cheers.
I will try and update and attempt to squash everything, and again if it turns into a mess - I'll close this one of and create a clean PR
One way to do it is to make a working branch for your next revision, add as many commits as you'd like to that, then simply make one squash merge commit back into print_guide_v2.
For example:
$ git checkout print_guide_v2 # Start with the branch that corresponds to this PR
$ git checkout -b pr307_revision_2 # Copy this branch, and use it for experimentation
$ git add [...]; git commit [...] # Make as many commits as you'd like to this pr307_revision_2 branch
$ git checkout print_guide_v2; git merge --squash pr307_revision_2 branch # Squash all commits from the experimental branch into one commit in print_guide_v2.
Once you push the one squashed commit in print_guide_v2, this PR will be automatically updated with that one commit. Hope this helps!
Hi Joe,
As you will have seen I have made a few changes and pushed everything up again.
As you will have also seen - I still didn't get the squash merge correct. I can only apologies for that.
With that said; happy for another round of feed back when you have time to review after the festive season.
If this needs further work I will create a clean branch and try again.
Merged. Thanks for putting the work into this!