ssh-audit icon indicating copy to clipboard operation
ssh-audit copied to clipboard

fix: Add space to fix URLs in terminal

Open its0x08 opened this issue 1 year ago • 1 comments

  • Added space between URL and ">" character which made the link show not found page because ">" becomes part of the URL

Example URLs:

  • https://github.com/jtesta/ssh-audit/issues>
  • https://github.com/jtesta/ssh-audit/issues%3E
  • https://www.ssh-audit.com/hardening_guides.html%3E
  • https://www.ssh-audit.com/hardening_guides.html>

Example New URLs:

  • https://github.com/jtesta/ssh-audit/issues
  • https://www.ssh-audit.com/hardening_guides.html

its0x08 avatar May 23 '24 13:05 its0x08

What OS platform and terminal did you notice this behavior in? I can't reproduce it on my system.

Also, last I heard (in the 1990's), the proper way to write URLs in places that do not support links (like on physical paper), is to enclose them in brackets. Maybe this is out-dated by now, but I haven't seen an official update about it.

jtesta avatar Jun 28 '24 18:06 jtesta

@its0x08: I'd be happy to investigate this further (and possibly merge this PR) if you're able to share what platform(s) the output is broken on. Otherwise, since I'm not seeing a problem on my Ubuntu systems, I'll close this for now.

jtesta avatar Sep 24 '24 21:09 jtesta