ssh-audit icon indicating copy to clipboard operation
ssh-audit copied to clipboard

more concise phrasing for (kex) ext-info-s [info]

Open perkelix opened this issue 1 year ago • 4 comments

What we currently have:

(kex) ext-info-s                          -- [info] pseudo-algorithm that denotes the peer supports RFC8308 extensions

What I recommend instead:

(kex) ext-info-s                          -- [info] supports RFC8308 extensions

perkelix avatar Mar 16 '24 08:03 perkelix

I think mentioning that ext-info-s is not a real key exchange algorithm is important. I don't know of a way to use less characters to convey the same level of meaning.

jtesta avatar Mar 19 '24 18:03 jtesta

I don't see why that aspect is so important.

Bttw, according to this, support for ext-info-c was also added. Do we test for this?

perkelix avatar Mar 21 '24 06:03 perkelix

Bttw, according to this, support for ext-info-c was also added. Do we test for this?

Yes.

jtesta avatar Mar 21 '24 22:03 jtesta

I think this comes down to personal preference. My own preference is to leave it as-is, but perhaps we can let the community vote on this.

If anyone would like this change made, put a thumbs-up emoji on this comment. Otherwise, if you'd like the output to remain as-is, put a thumbs-down emoji on this comment. Voting will remain open until Oct. 1 (for approximately 3 months). After that time, I'll follow whatever the community prefers.

jtesta avatar Jul 03 '24 01:07 jtesta