Jeff Terrace comments

Results 110 comments of


                                            Jeff Terrace

0.8 no longer exposes collada.DaeUnsupportedError which breaks DAE import in FreeCAD

It looks like it was removed in https://github.com/pycollada/pycollada/commit/3052d65cb7ca2478980a9254947a33533c4b6fe0#diff-f3b72bfc3c2aa923902de3bbe3e4ca85a5851511cd757e12b10bde6b5e8e377a But note that this exception class has always been in collada.common: https://pycollada.readthedocs.io/en/latest/reference/generated/collada.common.DaeUnsupportedError.html Users really should be importing from where it's defined, not...

"does not generate unique ID" errors

Yeah, I'm not convinced that's the right fix. It almost seems like it's reloading or something. But actually, I stopped seeing this error in the logs now on startup.

"does not generate unique ID" errors

Same for me, e.g. ``` 2024-03-05 17:29:37.494 ERROR (MainThread) [homeassistant.components.sensor] Platform open_epaper_link does not generate unique IDs. ID ap_ip already exists - ignoring sensor.ap_ip 2024-03-05 17:29:37.499 ERROR (MainThread) [homeassistant.components.sensor] Platform...

Error unloading entry xxx.xxx.xxx.xxx for camera

I get this on startup too, immediately followed by a bunch of log lines like this: ``` 2024-02-10 09:20:58.180 WARNING (SyncWorker_9) [custom_components.open_epaper_link.camera] Could not read image from file: /config/www/open_epaper_link/open_epaper_link.open_epaper_link.0000021a7d2b3b13.jpg 2024-02-10...

Onvif: In my opinion, the Line Detection Crossed Sensor should be available as a binary sensor.

The sensor you're talking about is implemented here: https://github.com/home-assistant/core/blob/dev/homeassistant/components/onvif/parsers.py#L702 I agree with you that it doesn't really make sense for this to be a diagnostic sensor. In fact, when I...

Onvif: In my opinion, the Line Detection Crossed Sensor should be available as a binary sensor.

@davidsauer000 the rule name should be part of the entity name: https://github.com/home-assistant/core/blob/dev/homeassistant/components/onvif/parsers.py#L693 Do you see it in your entity names?

Onvif: In my opinion, the Line Detection Crossed Sensor should be available as a binary sensor.

@JimGermany I think the process would be to update the code to call async_update_entity to update existing ones with the new device_class. I don't have a good way to test...

missing array2d.h?

I believe it's pfstools, array2d.h - https://github.com/Steve132/pfstools/blob/master/src/pfs/array2d.h

Export bumpmap

It looks like the bumpmap is coming from ``: https://github.com/pycollada/pycollada/blob/6b3dc7acb30b1c167efb2bb3cbe9b041afb1cfd8/collada/material.py#L663 Do you have some sample files with bumpmap in them that load in other programs we can add to the...

Replace numpy.delete(..., -1, 1) with slicing for better performance and readability

Feel free to send a PR