angular-chart.js icon indicating copy to clipboard operation
angular-chart.js copied to clipboard

upgrade chartjs to 2.5

Open csulok opened this issue 7 years ago • 3 comments

Overview

angularjs 1.5.11 angular-chart.js 1.1.1 chart.js 2.3.x

When installing the npm package, and building an application with browserify, require will use the chart.js release depended by angular-chart.js, specifically 2.3.x. Can you relax the version dependency to 2.x with a new version, or simply release a new version that depends on 2.5.x? The 2.4 and 2.5 releases of chart.js include important bugfixes I'd like to see in use, e.g.: https://github.com/chartjs/Chart.js/pull/3446

Please make sure to review and check all of these items:

  • [x] Use latest version of the library
  • [x] Make sure you've included all the dependencies e.g Chart.js, angular, etc.
  • [x] Include a repro case, see below.

csulok avatar Apr 28 '17 08:04 csulok

Is there a fork I can test?

AshMartian avatar May 23 '17 02:05 AshMartian

Created one #632

csulok avatar May 25 '17 19:05 csulok

Will do, seems to work without much modification.

On Thu, May 25, 2017 at 12:38 PM, Andras Stracz [email protected] wrote:

Created one #632 https://github.com/jtblin/angular-chart.js/pull/632

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jtblin/angular-chart.js/issues/627#issuecomment-304103513, or mute the thread https://github.com/notifications/unsubscribe-auth/ABLnnuM0_WKhVKXZ4hBHVCtm9wF9ZL4oks5r9djLgaJpZM4NLNta .

AshMartian avatar May 25 '17 23:05 AshMartian