angular-chart.js icon indicating copy to clipboard operation
angular-chart.js copied to clipboard

Change to watch objects by reference when one time binding

Open otaviodecampos opened this issue 7 years ago • 0 comments

Description of change

Because function "watchOther" every recreate charts, when labels updated, even by passing the list labels by reference, the chart is recreated and restarts animations.

Change to: If the attribute has one time binding (: :) notation, it compares the values by reference.

Pull Request check-list

  • [ ] Run gulp test to ensure there are no linting, or style issues and all tests pass.
  • [x] Squash your commits into a few commits only.
  • [x] Make sure the commit message is short, concise and descriptive of the issues you're fixing.
  • [x] Avoid mixing up multiple issues and/or features, open one pull request for each issue.
  • [ ] Have you updated the documentation and / or examples?
  • [ ] Have you included a new test?

otaviodecampos avatar Mar 15 '17 21:03 otaviodecampos