reaticulate icon indicating copy to clipboard operation
reaticulate copied to clipboard

Published 20 hours ago • verified publisher icon jtackaberry

Add banks for EastWest Hollywood Opus

Open xshill opened this issue 1 year ago • 4 comments

I created some user banks for the EastWest Hollywood Opus edition keyswitches. The ones we already had in the repo were for the Play engine, and the keyswitch instruments that come with the Opus engine are different.

xshill avatar Jun 04 '23 13:06 xshill

From what I could check my version has all available articulations while his has only the ones that came with the default Keyswitch instrument. Thats true at least for Woodwinds. MyVersion HisVersion

gbombadil avatar Jul 26 '23 05:07 gbombadil

@xshill can you confirm? Is #212 a superset of your PR? I don't have this library so there may be considerations I'm not aware of.

Thanks!

jtackaberry avatar Jul 27 '23 00:07 jtackaberry

Hello, just checking, how much time of waiting is appropiate in this cases?

Thanks in advance....

gbombadil avatar Sep 07 '23 02:09 gbombadil

@xshill can you confirm? Is #212 a superset of your PR? I don't have this library so there may be considerations I'm not aware of.

Thanks!

Holy crap, I'm so sorry about the late reply; Github never notified me or anything and I completely forgot to check back on this PR.

I took a quick look and it does indeed look like it implements more articulations that mine does (I only did the default articulations for keyswitch instruments, as mentioned).

Thanks @gbombadil !

Edit: I just realized it's only for woodwinds. So I think we can just replace the file userbanks/EastWest_Hollywood_Opus_Woodwinds.reabank with the bank that @gbombadil made, and keep the rest.

xshill avatar Dec 21 '23 23:12 xshill