flexrouter
flexrouter copied to clipboard
jtackaberry
Define rule for a range of notes
@jtackaberry Is it possible for you to implement This: defining a rule for a range of notes instead of doing single notes separately? For example, defining a rule quickly for redirecting C1 to C2 from midi channel 1 to C-2 to C-1 midi channel 2, instead of choosing one by one and select the target.
New version of this code is online now :) Timing, Transpose, Range and Velocity to CC features are there https://github.com/jerayan/flexrouter
@jerayan you prefer to maintain a fully separate fork rather than contribute a PR back to this project?
I can contribute this back, I tried once but not success...there was closed pull request
I tried once but not success...there was closed pull request
Hm, I haven't seen any PRs come through for FlexRouter. I do see #8 opened by you to request a feature, but you closed it a couple weeks later, I guess because forked FlexRouter at that time and implemented it yourself.
I can also cherrypick the features from your fork as well, I'm happy to do that. I'm receptive to PRs, but I'm certainly not opposed if you prefer to maintain a separate fork, especially if you don't want to deal with someone else's code review. :) It's all open source after all.
You can cherrypick the features.. I tried to handle your transpose feature as you wrote but I cannot handle that in the code, so I decided to make another solution and that puts me into another features...I would also like to make first note handling feature that can update timing of the first note in legato :) but have some work to do now.
út 15. 8. 2023 v 23:22 odesílatel Jason Tackaberry @.***> napsal:
I tried once but not success...there was closed pull request
Hm, I haven't seen any PRs come through for FlexRouter. I do see #8 https://github.com/jtackaberry/flexrouter/issues/8 opened by you to request a feature, but you closed it a couple weeks later, I guess because forked FlexRouter at that time and implemented it yourself.
I can also cherrypick the features from your fork as well, I'm happy to do that. I'm receptive to PRs, but I'm certainly not opposed if you prefer to maintain a separate fork, especially if you don't want to deal with someone else's code review. :) It's all open source after all.
— Reply to this email directly, view it on GitHub https://github.com/jtackaberry/flexrouter/issues/6#issuecomment-1679633306, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE42JQJEBM3SDVJ3Z5QKECDXVPSBHANCNFSM4E6PBV2Q . You are receiving this because you were mentioned.Message ID: @.***>
-- S pozdravem Dominik Svoboda