Joseph Szobody
Joseph Szobody
Well huh, I wasn't aware. I knew about the `$defer` property, but not the interface. I'll get this merged then, thank you.
You can already specify S3 using `s3://bucket/...` paths, just like for file sources. So both local and S3 destinations are already supported. Give that a try and let me know...
This is pretty funny. TaxJar sends tons of notices including an alarming "FINAL NOTICE" today about the need to upgrade, and yet the official TaxJar PHP library isn't ready?
It makes sense, I get it. Two things: 1) When adding files, I need a PSR7 stream, one that can provide filesize up front (prior to reading in the file...
@vanodevium I'm pretty convinced that we'll need to extract the filepath from the Storage facade, and still use `s3://bucket/path` internally. We can't make use of the Storage calls directly, with...
Hmm, interesting. I think I'd be more inclined to support a method to check for the existence of a file, and then you handle the decision yourself. Something like: ```...
Yes. It's just a major rewrite, and I haven't been able to prioritize that just yet. Hopefully soon.
@mbardelmeijer Is this holding back your application upgrade? We have Laravel 11 apps using this package currently without issue. I'm aware of some conflicts with other packages like Spatie's medialibrary,...
@mbardelmeijer If you are zipping files that are handled by spatie/medialibrary, are you aware that medialibrary can fully handle the zip stream? You might not need this package at all....
@mbardelmeijer Yep, got it. Makes sense.