eslint-plugin-react icon indicating copy to clipboard operation
eslint-plugin-react copied to clipboard

[Fix] jsx-newline: jsx-newline breaking with comments

Open akulsr0 opened this issue 9 months ago • 5 comments

Closes #3573

akulsr0 avatar May 03 '24 11:05 akulsr0

Can we rerun the failing test once?

akulsr0 avatar May 07 '24 06:05 akulsr0

yep, looks like a fluke; reran.

ljharb avatar May 07 '24 06:05 ljharb

Bumping this up!

akulsr0 avatar May 16 '24 13:05 akulsr0

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.76%. Comparing base (417e1ca) to head (9d6aa68). Report is 1 commits behind head on master.

:exclamation: Current head 9d6aa68 differs from pull request most recent head 7722f49

Please upload reports for the commit 7722f49 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3747      +/-   ##
==========================================
- Coverage   97.79%   97.76%   -0.04%     
==========================================
  Files         134      134              
  Lines        9613     9614       +1     
  Branches     3486     3486              
==========================================
- Hits         9401     9399       -2     
- Misses        212      215       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 29 '24 15:05 codecov[bot]

I remember the same issue mentioned in #3573 was happening for me too, which got fixed by this. But now I am unable to reproduce it :(

akulsr0 avatar Jun 01 '24 03:06 akulsr0