eslint-plugin-react icon indicating copy to clipboard operation
eslint-plugin-react copied to clipboard

[Fix] False negative when rel attribute assigned using ternary

Open V2dha opened this issue 1 year ago • 2 comments

Fixes #2962

V2dha avatar Jul 13 '22 02:07 V2dha

Codecov Report

Merging #3332 (0bf8373) into master (337e41a) will increase coverage by 0.27%. The diff coverage is 100.00%.

:exclamation: Current head 0bf8373 differs from pull request most recent head b7f388b. Consider uploading reports for the commit b7f388b to get more accurate results

@@            Coverage Diff             @@
##           master    #3332      +/-   ##
==========================================
+ Coverage   97.49%   97.76%   +0.27%     
==========================================
  Files         123      123              
  Lines        8861     8833      -28     
  Branches     3238     3219      -19     
==========================================
- Hits         8639     8636       -3     
+ Misses        222      197      -25     
Impacted Files Coverage Δ
lib/rules/jsx-no-target-blank.js 92.96% <100.00%> (+4.07%) :arrow_up:
lib/rules/forbid-prop-types.js 100.00% <0.00%> (ø)
lib/util/Components.js 98.96% <0.00%> (+2.48%) :arrow_up:
lib/util/jsx.js 95.60% <0.00%> (+3.29%) :arrow_up:
lib/rules/no-unstable-nested-components.js 98.25% <0.00%> (+3.48%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 13 '22 02:07 codecov[bot]

@V2dha i've rebased this, and there's still 48 test failures - all things that expect an error but now get none. I think the some/every change may be related.

ljharb avatar Aug 04 '22 23:08 ljharb