eslint-plugin-react icon indicating copy to clipboard operation
eslint-plugin-react copied to clipboard

Published 20 hours ago • verified publisher icon jsx-eslint

Fix link to link-type-noreferrer

Open Luccasoli opened this issue 2 years ago • 4 comments

I updated the link to the "noreferrer" explanation instead of a link to the "noopener" explanation, since the paragraph where this link is located only talks about the "noreferrer".

Luccasoli avatar Jul 04 '22 12:07 Luccasoli

Codecov Report

Merging #3319 (5cf46ca) into master (23121e0) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3319   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files         123      123           
  Lines        8873     8873           
  Branches     3244     3244           
=======================================
  Hits         8655     8655           
  Misses        218      218

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 04 '22 12:07 codecov[bot]

What's wrong with https://html.spec.whatwg.org/multipage/links.html#link-type-noopener ?

ljharb avatar Jul 05 '22 06:07 ljharb

Hi @ljharb, what's up?

Sorry for the PR without context..., I suggested this change because this paragraph I edited talks about the "noreferrer" configuration instead of "noopener", so I thought this link would be more appropriate, what do you think?

Luccasoli avatar Jul 05 '22 11:07 Luccasoli

Let's include both links.

ljharb avatar Jul 05 '22 16:07 ljharb