DontF-WithPaste icon indicating copy to clipboard operation
DontF-WithPaste copied to clipboard

Feature/unblock more events

Open ktully opened this issue 6 years ago • 6 comments

Unblock copy and paste on more sites, and unblock cut in general

  • Add cut to the list of events which can be unblocked

  • Unblock on sites which capture Ctrl key or right-click events

  • Unblock accessing the context menu

  • Unblock selecting text to copy when outside form inputs

  • Add tests for all the above

  • Fix some intellij JS warnings

  • Rename some functions - possibly controversial :)

The new unblockings will probably break some sites with rich content editors, necessitating more use of the site whitelist/blacklist by users.

ktully avatar Mar 11 '18 13:03 ktully

May resolve #47 as a side-effect

ktully avatar Mar 11 '18 13:03 ktully

@jswanner if I resolve the conflicts with your 2.0 updates (and follow the new pattern for deregistering event handlers when the extension is deactivated), is this a merge request you're likely to accept?

How do you feel about me renaming allowCopyAndPaste() in content.js?

ktully avatar Mar 14 '18 22:03 ktully

@ktully firstly, thanks for caring enough to make the changes and the PR.

I've been debating with myself over how I feel about these changes -- with the exception of cut events, which I should have thought about when I accepted the PR that added copy events.

I certainly would not have wanted to merge this with version 1, since with the default configuration those event handlers would have run on the majority of pages, causing far more harm than good. Now that I've released v2 (setting aside the negative feedback), I'm more open to the idea of the extension intercepting these additional events.

jswanner avatar Mar 14 '18 23:03 jswanner

How do you feel about me renaming allowCopyAndPaste() in content.js?

I'm fine with it being renamed, but I would probably call it something along the lines of forceBrowserDefault.

jswanner avatar Mar 14 '18 23:03 jswanner

@ktully Why is your fork DontMessWithPaste instead of DontFuckWithPaste ?

:disappointed: that you removed the emotional expletive that increases our satisfaction to use this addon

nitrocode avatar Mar 29 '18 21:03 nitrocode

https://www.cloudbet.com/ also blocks pasting into their "Stake" input fields. If someone has the leisure, you could go through https://www.cloudbet.com/public/js/desktop_cecc931.js and figure out how.

kwaaak avatar Apr 11 '18 20:04 kwaaak