Delweng
Delweng
> classic piece of code that needs a unit test @emhane as we already had an test case for this function in https://github.com/paradigmxyz/reth/blob/3c8251b40253e92112e82e209026aa36cde0dc85/crates/storage/provider/src/bundle_state/bundle_state_with_receipts.rs#L1179-L1195 so I add a simple unit test...
I will try to implement a benchmark tool and give a reasonably comparative result based on concurrency and data volume.
> Hey @jsvisa! Let me know if you are blocked on something here 😊 Sorry for the long and late response, I'm not familiar with Rust, I think I can...
> Looks good from my side, all we need now is a benchmark, you can see some examples here: https://github.com/paradigmxyz/reth/tree/main/crates/trie/benches thank you, try to implement it this weekend
@mattsse @onbjerg Sorry for the delay of updating this PR. I've added the benchmark, and the result below:
> I compare state results on builders addresses. Here is 0.00000422664333 state diff for beaverbuild. But Geth prints 0.000146000760003 @fridary I think the result is because the burned_fee was not...
> @jsvisa how can I calculate/find/query burned fee? I did not understand your example where you got it. Or burned fee is just a block's base fee? My example transaction...
> We should instead try to fill the value. @s1na sorry for the inconvenience, I think I'll buy it.
Filled it with vm.opcode, kindly ask @s1na @ziogaschr to take a look.
BTW, as we use `callType` for the different call types, how about use the name `createType` instead of `creationMethod`?