visidata-plugins icon indicating copy to clipboard operation
visidata-plugins copied to clipboard

dedupe plugin SHA256 does not match!

Open asfaltboy opened this issue 3 years ago • 4 comments

Hi, I'm trying to install the plugin, I've tried this in visidata 2.4 as well as after upgrading to 2.6.1.

Apparently the 2.x version strips whitespace before hashing, and encodes to utf-8 ; too bad the docs weren't properly updated. There's now a utility in visidata/dev/vdhash.py to create a similar hash. I ran it and it generated this hash:

94cc1b0afcf7dbcbe93ca421104a2252c411448d59ba75df00ae455d3577934a

I tried setting in the open-plugins settings, and it fixed the issue. If you're happy, I can submit a PR to saulpw/visidata to correct the plugin hash there, as well as maybe some docs (if I can find them)

asfaltboy avatar Sep 30 '21 17:09 asfaltboy

@asfaltboy This is my fault! I forgot to update the plugins.jsonl on visidata.org. I will update it right now!

anjakefala avatar Sep 30 '21 20:09 anjakefala

It is now updated. =) Please erase your cache in ~/.visidata/cache. Thanks for letting us know!

anjakefala avatar Sep 30 '21 20:09 anjakefala

Which docs were not properly updated? I just checked the docs in the pull request template, and the link to vdhash.py is there: https://www.visidata.org/docs/contributing/#plugins

anjakefala avatar Sep 30 '21 21:09 anjakefala

Which docs were not properly updated?

Ah I didn't see this contributing page, I only found the plugins page, which linked to the API docs, which also have a plugins page and that page mentions the previous method of generating a SHA256 hash of the plugin.

asfaltboy avatar Oct 01 '21 08:10 asfaltboy