James Sumners
James Sumners
> @jsumners in context of - [#156 (review)](https://github.com/pinojs/pino-std-serializers/pull/156#pullrequestreview-2420664166) > > > This is not a good idea. Cookies typically contain sensitive information. The purpose of these standard serializers is to...
```js 'use strict' const http = require('node:http') const serializers = require('pino-std-serializers') const logger = require('pino-http')({ serializers: { req: serializers.req, res: serializers.res } }) const server = http.createServer(handler) server.listen(0) http.get(`http://localhost:${server.address().port}/`, {...
@mcollina I think we both misunderstood the intent of #156. What it is doing is adding yet another framework specific compatibility like these: https://github.com/pinojs/pino-std-serializers/blob/1a136f6549fb09d1820b2d30f21cd765a95a6aba/lib/req.js#L66-L67 https://github.com/pinojs/pino-std-serializers/blob/1a136f6549fb09d1820b2d30f21cd765a95a6aba/lib/req.js#L71-L74 I think what was missing...
@MDAkramSiddiqui a response will come when @mcollina is able to get to it.
I understand. But this is not the only thing either of us maintain. And Matteo has a very high load to work through.
> I'm against showing up cookies by default, as it would be a significant security risk and a log of PII (which would violate GDPR). Then we need to patch...
Please provide details on what you are expecting. Is this request for the CLI tool?
> issue title is rather self-explanatory If that were the case I wouldn't have asked for more detail. So, yes, you are looking for environment variable support in the CLI...
I don't agree that this is an issue. This is a well established design pattern that unifies the look of the page but provides highlighting for targeted elements.
What is being put up "again for discussion"?