James Sumners

Results 793 comments of James Sumners

It's easy to wrap a Pino instance. There's no need to mess with its prototype.

Because object inspection is expensive. We merely look for keys that have been configured to have serializers before attempting to apply any serializers. You are welcome to use the `logMethod`...

Use a hook -- https://github.com/pinojs/pino/blob/613d700fc2b77768bbbc84095a5cc28fb745b10d/docs/api.md#logmethod

> Perhaps it should just be a dependency? https://github.com/pinojs/pino/pull/699

I don't understand the issue. Line 160 is running the object and message through the JSON serializer. Line 171 is writing the actual generated log line, as a single string...

@delvedor is this double invocation expected with the formatter implementation you added?

We cannot guarantee acceptance without first being able to review the substance. What we can guarantee is that it will be considered. I think it would be acceptable to add...

Please read the text in that section of the docs prior to that code sample. It very clearly explains the example.

Literally the first sentence in your quote describes when a string will be passed in. If you want to write a prettifier that doesn't support CLI usage, that's your prerogative....

I don't think anyone on the team has used Bunyan in so long that we would be able to accurately write such a document. We'd certainly welcome a PR that...