James Sumners

Results 658 comments of James Sumners

I thought I read "not sure what others feel about changing the default query string parser."

If we are going to change signatures, may I suggest we go for parameter objects at the same time? ----- benchmark.js ```js 'use strict' const Benchmark = require('benchmark') const suite...

Node 18 is very likely going to be the minimum supported version for the next LTS. I think all of the posted benchmark results show that `boundThisAndParamsObject` is sufficiently "fast"...

How is this better than using existing tooling like https://curl.se or https://github.com/Orange-OpenSource/hurl?

> but introspecting and manipulating the business logic code implementing the requests How would you do this?

> Depends entirely on how you've put together your business logic. My question was really more along the lines of: You said "manipulating the business logic code". How would you...

Is this still applicable?

> I don't think it is a valid `content-type`. `application/msgpack; charset=utf-8` would be a valid one. Note the difference between `,` and `;`. Incorrect. These two content types are equivalent:...

Ah, yes, in that case this is unsupported and not an error we should handle. If a service needs to handle such invalid cases then they can pass their own...

I believe that PR shows a change to the documentation that would indicate how to reformat the time.