James Sumners

Results 658 comments of James Sumners

> If a, then it makes sense to me that the limit would be the frameworks that are being used by the target audience Fastify wants to switch to Fastify,...

I rather just remove the offending modules.

1. CJS isn't "legacy" 2. ESM does not work the same way 3. ESM is not instrumentable

Would you like to send a Pull Request to address this issue? Remember to add unit tests.

I do not understand the issue. Is ldapjs returning an error?

Are you able to provide a reproduction test case in our integration tests (on the `next` branch)?

I am unclear why one would even need to minify/uglify this library. The intention of this library is to be used in a Node.js environment. Minification does nothing in such...

My initial inclination is that what you are describing is a poor way to determine if a new connection is being used. Are you saying that you're referencing this: https://github.com/ldapjs/node-ldapjs/blob/dadac0c36ca6bfdb34b0ca4963f814ca3610b2f2/lib/client/client.js#L808-L809

I still don't know what information you are trying to obtain. I did not write this library and so am not familiar with all of its intimate details. I need...

@tastypackets if you have time to come back to this I would be very willing to look at a PR. If so, please create the PR against the `next` branch...