James Sturtevant

Results 650 comments of James Sturtevant

https://github.com/containerd/nerdctl/issues?q=is%3Aopen+is%3Aissue+label%3Aplatform%2FWindows

We discussed these changes at the last sig-windows meeting and shared some links. @claudiubelu Let me know if need anything else

@claudiubelu I moved the windows periodic unit test to community yesterday which can be used as an example: https://github.com/kubernetes/test-infra/commit/691c90667b55aa508ae9e5b6022b06f33ef15cc0

This makes sense, if its a common occurrence maybe it makes sense to improve the error message? I think it should be possible to inspect the wasm component to see...

> Is there a compelling reason not to roughly match the naming convention adopted for Linux in #1253? For cpu's, Linux is a simple list where as on windows it...

/lgtm for the functionality, I will defer to the reviewers here on the naming discussion

LGTM @tianon @kevpar @kolyshkin could you give a final look?