ace-jump icon indicating copy to clipboard operation
ace-jump copied to clipboard

Please add support for VS2022

Open kgfly opened this issue 3 years ago • 10 comments

My box has both VS19 and VS22 installed. But ace-jump cannot detect VS22 during the installation, etc

image

Thanks

kgfly avatar Nov 21 '21 16:11 kgfly

I no longer work with VS but I am willing to accept a PR

jsturtevant avatar Nov 25 '21 06:11 jsturtevant

Sorry, I don't know how to do that. Let's see if some one can help out or not.

kgfly avatar Nov 30 '21 07:11 kgfly

VS2019 is a x86 exe while VS2022 is a x64 exe. I am not sure how much impact on the plugin.

kgfly avatar Nov 30 '21 07:11 kgfly

Hi @jsturtevant , following VS19 support commit, https://github.com/jsturtevant/ace-jump/commit/5fb1a14e21bdd1d6cc7711c744e29d1b2f137353,

I made some change https://github.com/jsturtevant/ace-jump/pull/20.

But it does not work, etc image

Do you know why it does not work?

kgfly avatar Dec 04 '21 01:12 kgfly

Try the release in my Fork: https://github.com/AaronMaria/ace-jump/releases/tag/v1.5 It should work with Visual Studio 2022

AaronMaria avatar Dec 06 '21 19:12 AaronMaria

Hi @AaronMaria , I tried to build your branch. But it does not work. May you please fix the build failure?

kgfly avatar Dec 07 '21 01:12 kgfly

Hi @kgflying, I assume it was an issue with the references, I think I fixed it, can you pull the latest version and try again? If it still doesn't work, please tell me the error message you receive.

AaronMaria avatar Dec 07 '21 11:12 AaronMaria

Thanks for all the effort here, if it works could we get #20 updated so we can get an official release out?

jsturtevant avatar Dec 09 '21 17:12 jsturtevant

Thanks, guys. I found another more powerful plugin and it already has VS22 support, https://github.com/msomeone/PeasyMotion/issues/24

I will switch to that plugin and unsubscribe this thread. Please feel free to close this thread if needed.

Thanks again.

kgfly avatar Dec 30 '21 19:12 kgfly

Try the release in my Fork: https://github.com/AaronMaria/ace-jump/releases/tag/v1.5 It should work with Visual Studio 2022

It works for me!

andy505050 avatar Jan 26 '22 01:01 andy505050