github-stats icon indicating copy to clipboard operation
github-stats copied to clipboard

Error displaying images with "Languages Used (By File Size)"

Open NhanAZ opened this issue 3 years ago • 7 comments

Error description photo

Error photo

Device used in the photo

Android 11; Redmi Note 8 Build/RKQ1.201004.002

Browser version used in the photo

Chrome 96.0.4664.92

NhanAZ avatar Dec 13 '21 02:12 NhanAZ

Thanks for the details in the bug report! I was able to replicate this in Chrome on Desktop (see attached video). The issue appears to be with some internal padding value in the CSS. I will leave this open for documentation until I can fix the problem.

https://user-images.githubusercontent.com/7355528/145781663-15ba0dc4-8f89-49a8-8119-d65b8e131e58.mp4

jstrieb avatar Dec 13 '21 08:12 jstrieb

For anyone who is considering working on this, but is intimidated or unsure how to get started, I would be happy to help! Feel free to post any questions in this thread. A fix would involve you forking the repository, making some changes, committing and pushing those to your fork, and making a pull request on GitHub that we can work together on until it's ready to merge. At the end, your GitHub profile will be listed as a "contributor" on this repo!

I expect (i.e., guess) that the places where the file might need to be changed are probably some or all of:

  • https://github.com/jstrieb/github-stats/blob/60ba361bdbce1e4664d87d529477aae3e5391b22/templates/languages.svg#L11
  • https://github.com/jstrieb/github-stats/blob/60ba361bdbce1e4664d87d529477aae3e5391b22/templates/languages.svg#L21
  • https://github.com/jstrieb/github-stats/blob/60ba361bdbce1e4664d87d529477aae3e5391b22/templates/languages.svg#L100

If you want to try fixing this, you should go through the values in the list above and play around with them in the generated/languages.svg file until something works. Then, commit the changes in templates/languages.svg. After that, we can work together to test in other browsers and make sure everything looks right.

Thanks in advance to anyone who takes the time to help out with this!

jstrieb avatar Jan 12 '22 06:01 jstrieb

Hey @jstrieb I was wondering if I could attempt to help with this one?

Froderick-Fronkensteen avatar Jan 15 '22 22:01 Froderick-Fronkensteen

Hey @jstrieb I was wondering if I could attempt to help with this one?

Hey @Froderick-Fronkensteen, please do! If you can get it fixed, make a PR, and we can work to try it on some devices and get it merged in. Thanks for your interest in the project!

jstrieb avatar Jan 15 '22 23:01 jstrieb

Hey @jstrieb, if this issue hasn't been resolved yet, I would like to work on it.

vidit21srivastava avatar Mar 23 '22 10:03 vidit21srivastava

Hi @vidit21srivastava! This issue has not yet been resolved, and I would appreciate your help with it.

jstrieb avatar Mar 26 '22 00:03 jstrieb

Hey @jstrieb , first I was thinking that the "height" of "foreignObject" is causing the problem. But later I got a strange thing. What is this class doing here? By removing it's "height" everything is ok. image

Please checkout that.

NazmusSayad avatar Jun 07 '22 14:06 NazmusSayad