delayed_paperclip icon indicating copy to clipboard operation
delayed_paperclip copied to clipboard

delayed paperclip broken under paperclip 2.5.0

Open aguilarsoto opened this issue 12 years ago • 13 comments

the 'most_appropriate_url' has being removed from the attachment and now we are back using simple 'url' calls and that calls most_appropriate_url from url_generator.

Regards, Marco Aguilar

aguilarsoto avatar Jan 29 '12 17:01 aguilarsoto

Hi Marco, I have tried this patch, however I get the following error:

wrong number of arguments (2 for 0)
/home/atd/dev/social_stream/documents/lib/delayed_paperclip/social_stream-documents.rb:37:in `url_with_processed'
/home/atd/.rvm/gems/ruby-1.9.2-p180/gems/paperclip-2.5.2/lib/paperclip/interpolations.rb:50:in `url'
/home/atd/.rvm/gems/ruby-1.9.2-p180/gems/paperclip-2.5.2/lib/paperclip/interpolations.rb:34:in `block (2 levels) in interpolate'
...

It seems url_with_processed takes several arguments.

atd avatar Jan 30 '12 10:01 atd

ups sorry about that let me make sure I revert the most_appropriate_url completelly then

aguilarsoto avatar Jan 30 '12 13:01 aguilarsoto

@atd, giving this solution a little more thought the problem is that the default_url method of paperclip was moved to url_generator and now its private. still working on it.

aguilarsoto avatar Jan 31 '12 13:01 aguilarsoto

Any update on this? Upgrading to 3.2.1 and would love to continue using this :)

nateleavitt avatar Feb 07 '12 16:02 nateleavitt

https://github.com/aguilarsoto/delayed_paperclip this is what I end up doing if anyone wants to review it and get back to me. @atd your comments will be most appreciated

aguilarsoto avatar Feb 07 '12 20:02 aguilarsoto

Let me see if I can find some time to test it..

atd avatar Feb 09 '12 09:02 atd

I'll test over the next couple days.

nateleavitt avatar Feb 09 '12 18:02 nateleavitt

Whats the status of this? Just wondering if anyone else should jump in to help or its too close to being pulled?

tommeier avatar Feb 20 '12 03:02 tommeier

@aguilarsoto I installed the other repository (referenced earlier) as a plugin and everything seemed to load fine. However, I'm not getting a delayed_job created for the background processing. Maybe I have something messed up...

nateleavitt avatar Feb 22 '12 22:02 nateleavitt

I've tested this too, updated to 2.7 paperclip, though the tests pass, when used in an app they never seem to reach a 'completed' stage, stalling at the 'saving image' phase. My guess is its not hitting the post processing method as in the past. I'll try and have a look soon.

tommeier avatar Mar 02 '12 10:03 tommeier

Update : My issue was mostly related to the combination with "paperclip-meta" gem, which is now resolved : https://github.com/y8/paperclip-meta/pull/10 , I also wasnt sure about the use of UrlGenerator in that way, and just monkey patched it for now, but made notes on how it should be done properly later : https://github.com/jstorimer/delayed_paperclip/pull/61

With both updates, confirmed to work on Rails 3.2.2 and Paperclip 2.7.

tommeier avatar Mar 04 '12 10:03 tommeier

Any plans to release this?

phene avatar Apr 17 '12 00:04 phene

Updated : Now on 3.1.2 : https://github.com/jstorimer/delayed_paperclip/pull/69

tommeier avatar Jul 02 '12 01:07 tommeier