Jonathan Stone

Results 160 comments of Jonathan Stone

Thanks for putting this proposal together, @C0rn3j! Since we're currently focusing development efforts on MaterialX 1.39, would you mind targeting this pull request to the `dev_1.39` branch of MaterialX, and...

This is a great catch as well, thanks @HardCoreCodin. If you have the bandwidth to address the two issues that you caught, feel free to propose PRs for these!

@christian-heusel We could use some additional context on this one, as it's not an issue that we've yet heard about from other teams integrating MaterialX and USD!

@christian-heusel Is this an issue that requires the full Blender application for a repro, or are there ways to trigger this using MaterialX or USD/MaterialX alone? And with respect to...

Ah, I see what you mean, @svenstaro. As far as I know, neither the USD nor MaterialX projects provide ABI compatibility between released versions, but we can likely do a...

Good catch, @HardCoreCodin, and here is the line of code that ought to be modified to address this in MaterialX shader generation: https://github.com/AcademySoftwareFoundation/MaterialX/blob/main/source/MaterialXGenShader/Nodes/ConvertNode.cpp#L31

I believe this issue will be addressed by upcoming PR #1905, though the resolution in this PR actually updates the specification to match the current behavior of the MaterialX nodes.

@ld-kerley In this case, I think it's better to follow your current approach, where the codebase behavior is considered canonical, and the specification is updated to match. Both interpretations seem...

@HardCoreCodin Here's the code that handled these conversions in the previous release of MaterialX, if you'd like to compare @ld-kerley's latest implementation against the historical behavior of the codebase: https://github.com/AcademySoftwareFoundation/MaterialX/blob/v1.38.10/source/MaterialXGenShader/Nodes/ConvertNode.cpp#L34...

This is a good question, @MatthieuBEAUD, and I'm CC'ing @kwokcb who has done some initial work on adding NodeDef publication methods to the MaterialX API. One related pull request may...