react-typist icon indicating copy to clipboard operation
react-typist copied to clipboard

#6 add an option to repeat animation

Open ammarbinfaisal1 opened this issue 5 years ago • 5 comments

Any changes required to this?

ammarbinfaisal1 avatar Oct 24 '18 16:10 ammarbinfaisal1

@jstejada You should definitely merge this, it is a real use case of this library and needed.

ekremkenter avatar Nov 01 '18 09:11 ekremkenter

@jstejada Can u merge it, please? Really useful feature

npupko avatar Feb 06 '19 10:02 npupko

For anyone else that needs the repeat option I've published @ammarbinfaisal 's fork as react-typist-n10. You just need to add repeat as a prop on the Typist component.

chrisabrams avatar Feb 27 '19 18:02 chrisabrams

thanks for doing this! I'll need to think if we really need to merge this in, since there are alternatives without having to update this component itself: #6

jstejada avatar May 17 '19 18:05 jstejada

@jstejada so?

I believe the other options listed in #6 are workarounds only. The key prop must be(miss) used alot already to fix things - for example in #29

Having a repeat option at least eliminates one of them.

ohlr avatar Mar 22 '20 12:03 ohlr