Jon Steinich

Results 119 comments of Jon Steinich

This is a tough one. I certainly understand the motivation for doing this; however, the usage is definitely less clean.

Were the synth benchmarks for locally generated providers? Would be interesting to compare with the published bindings. While JSII has some fundamental slowness to it, we've seen some glaring performance...

> Do you mean profiling the synth operation? Yep. Should also profile the get operation, but that didn't feel like the focus of this PR.

Quick analysis of the impact of this change to user experience: - All languages - Users will generally require more import statements. I tend to let the IDE handle generating...

The auto naming is treating them both as having the name `aws`. This results in the output being partially overridden. You can manually specify the names so that don't collide:...

If you are just using the aws provider (or a few others), you could use [pre-built provider packages hosted on PyPi](https://pypi.org/project/cdktf-cdktf-provider-aws/) (or similar for other languages). > The contents were...

> Would it be enough to just add a dependency to the Pipfile, or is there something that cdktf needs as well? Yep

> Added benefit: I won't even need to install cdktf-cli into the build container any more. 😃 Running without the cli isn't exactly the same as running your app directly....

> It would be great have a full overview of the differences somewhere, though Agreed. https://github.com/hashicorp/terraform-cdk/issues/798 > Which resources would have naming issues? Resources that are direct children of the...

Might also want to consider https://github.com/actions/stale