suri icon indicating copy to clipboard operation
suri copied to clipboard

Published 20 hours ago • verified publisher icon jstayton

feature/integrate Dockerfile for building a docker image

Open maxkratz opened this issue 4 years ago • 3 comments

Hey @jstayton,

I've created a Dockerfile to build a docker image for suri. There are also some new commands in the readme file. Please let me know if you require some changes.

Max

maxkratz avatar Nov 24 '20 12:11 maxkratz

Hey Max,

Thanks for this!

I'm not super up-to-speed with the latest in the world of Docker – other than using Compose to run dependencies like databases and such – so let me digest this for a bit.

One initial question: Is this meant for easier development, or deploys to production, or both?

Thanks again!

jstayton avatar Nov 24 '20 20:11 jstayton

You're welcome!

To answer your question: The reason to build this image (at least for me) was deployment to production. By using this image, I do not have to install nodejs on my server. Furthermore, it is easier to build the static site with CI, because the CI does not have to install all dependencies of your project for each commit in pipeline.

maxkratz avatar Nov 24 '20 21:11 maxkratz

Some changes to this PR:

  • Updated the Docker base image from Ubuntu 20.04 to Ubuntu 22.04
  • Updated the used Node version to 14 (because suri only works for >=14)

Any news on merging this?

maxkratz avatar Mar 19 '23 09:03 maxkratz