Justin Starry

I think we can discuss in https://github.com/solana-foundation/solana-improvement-documents/pull/116 instead, this PR is just for a bugfix.

This should definitely not be reverted. It's a bugfix regardless of whether we ship snapshot changes or not. We only include epoch rewards status in the snapshot if the partitioned...

I don't disagree that a refactor of transaction / message types should be done at some point but I would like to point out that the plumbing for `reserved_account_keys` is...

> Is it possible to break this up into logical commits? Right now, review is horrible. I split it up.. apologies for not doing that earlier! The PR description includes...

Would you prefer I open a pr for each individual commit? Also, considering that 2.0 is coming soon, breaking changes should be an issue?

@CriesofCarrots @t-nelson ping on this!

@CriesofCarrots I just rebased!

> Might it be better if it filters out tx that are already locked before checking the max block cu limits? I'll create a new issue for this, thanks for...

Superseded by https://github.com/solana-labs/solana/issues/34825

Thanks for reporting! Looks like the `serde_json` deserializer always calls `visit_u64` and `PrefixVisitor` doesn't implement that method. I'll fix it